fix: remove linear indexing from getindex adjoints #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/linear-indexing
branch
from
19f1282 to
e56b3da
Compare
This definition was surprising to me. I epected it to return a |
|
It doesn't have an underlying tuple, it's an array of arrays. But yes, that is probably not right, it probably should recurse running adapt. |
|
do you have a test case that is sensitive to this? |
|
I made #434, but the tricky thing is always that GPUArrays cannot have other GPUArrays, so the structure would need to be Array of GPUArrays and I think VectorOfArray works out in that case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.